Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an issue where we were not properly filtering projects #5309

Merged
merged 3 commits into from
Feb 19, 2019
Merged

Fix an issue where we were not properly filtering projects #5309

merged 3 commits into from
Feb 19, 2019

Commits on Feb 19, 2019

  1. Fix an issue where we were not properly filtering projects 

    There were some edge cases where the `public` queryset method on Project’s and Version’s could return an empty list. This lead to not properly filtering the queryset in the docsearch API. Properly raise an exception in this case, so that we don’t return search results that aren’t properly filtered.
    @ericholscher @humitos
    ericholscher authored and humitos committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    b000284 View commit details
    Browse the repository at this point in the history

  2. Fix test by making version active so it's returned

    @ericholscher
    ericholscher committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    732786c View commit details
    Browse the repository at this point in the history

  3. Clean up docstring

    @ericholscher
    ericholscher committed Feb 19, 2019
    Configuration menu
    Copy the full SHA
    d0b5eb6 View commit details
    Browse the repository at this point in the history