Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs reformatting with :guilabel: #5161

Merged
merged 7 commits into from
Feb 12, 2019
Merged

Docs reformatting with :guilabel: #5161

merged 7 commits into from
Feb 12, 2019

Conversation

csranasinghe
Copy link
Contributor

Refactoring the docs by replacing Admin menu guidance with :guilabel: sphinx role for all the docs. This is a fix to issue #5137

@dojutsu-user
Copy link
Member

Thanks @rexzing 🎉
Someone from the core team will review this.

stsewd
stsewd requested changes Jan 24, 2019
View reviewed changes
Copy link
Member

@stsewd stsewd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Just requesting some minor changes.

docs/advertising/ethical-advertising.rst Outdated Show resolved Hide resolved
docs/guides/build-notifications.rst Outdated Show resolved Hide resolved
docs/guides/build-notifications.rst Outdated Show resolved Hide resolved
docs/webhooks.rst Outdated Show resolved Hide resolved
docs/webhooks.rst Outdated Show resolved Hide resolved
@csranasinghe
Copy link
Contributor Author

Sure... I will do these changes.

@csranasinghe
Copy link
Contributor Author

Should I close this PR and send a new one or is there a way to add changes to this PR?

@dojutsu-user
Copy link
Member

You can checkout on this branch, make and commit changes and then push them.
It will appear here.
No need of new PR.

@csranasinghe
Copy link
Contributor Author

I added the requested changes

stsewd
stsewd reviewed Jan 28, 2019
View reviewed changes
docs/webhooks.rst Outdated Show resolved Hide resolved
stsewd
stsewd previously approved these changes Feb 5, 2019
View reviewed changes
humitos
humitos previously approved these changes Feb 6, 2019
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thanks.

@ericholscher ericholscher dismissed stale reviews from humitos and stsewd via 2ec2bba February 12, 2019 20:20
@ericholscher ericholscher merged commit 76972df into readthedocs:master Feb 12, 2019
@csranasinghe csranasinghe deleted the guilabel-reformatting branch February 18, 2019 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos left review comments

@stsewd stsewd stsewd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@csranasinghe @dojutsu-user @humitos @stsewd @ericholscher