Install ProBot #5082

humitos · 2019-01-09T10:04:50Z

This PR adds config files for Stale and No Response and todo

Stale

This bot will

check for issues that has no activity for 45 days
post a comment communicating this issue is becoming stale
tag the issue as Status: stale

After 7 days the issue was tagged as Status: stale if there was no activity, it will be closed.

NOTE: Accepted, Needed: design decision and Status: blocked are exempt of this flow. They won't be closed.

No Response

This bot will

check for issues marked as Needed: more information
if the issue was tagged more than 14 days ago the bot will close it

todo

This bot will create an issue every time that we push a # TODO: in our code with the message and the lines affected.

Delete Merged Branch

https://probot.github.io/apps/delete-merged-branch/

This bot will just delete branches that are merged automatically.

Reminders

https://probot.github.io/apps/reminders/

This bot will help us with issues for our Abandoned Project Policy

There are more bots that could help us to manage our repositories.

Dep: block PRs to be merged if depends on another issue/pr. We need to create a proper label for this
Mergeable: block PRs to be merged based on customizable rules. We need to check these rules and make some decisions.
Top Issues: label an issue as Top based on 👍's. This will help us to know which are the issues that users want more than others. We need to create a label for this one.

I think we can grow from here after we see how it works and how our flow is affected. At the moment I only request these bots to be installed in rtfd/readthedocs.org but I'd like if we can configure them in all of our repos, though.

Closes #4111

This bot will help us to close issues after requesting more information to the user that reported it.

This bot will help us to clean up our repository and stay with issues that are actionable and we do want to work on them at some point. So, after some inactivity the bot will post a comment and if nobody responds to it, the issue will be closed.

stsewd · 2019-01-09T15:03:58Z

NOTE: Accepted, Needed: design decision and Status: blocked are exempt of this flow. They won't be closed.

What about the bug label?

Top Issues: label an issue as Top based on +1's. This will help us to know which are the issues that users want more than others. We need to create a label for this one.

We can already filter by emojis in github

Mergeable and dep looks good, but not sure if they are really helpful, we can just leave a comment.

check for issues marked as Needed: more information
if the issue was tagged more than 14 days ago the bot will close it

We need to relabel some issues, I'll do that now.

stsewd · 2019-01-09T15:06:05Z

.github/config.yml

+  autoAssign: false
+  blobLines: 7
+  caseSensitive: true
+  keyword: "TODO"


we also have fixme and xxx in our code, some are in lowercase.

This will work only for new code, anyway. The bot does not accept multiple keywords as far as I know and TODO is the standard way.

stsewd · 2019-01-09T15:08:03Z

.github/no-response.yml

+  to our request for more information from the original author. With only the
+  information that is currently in the issue, we don't have enough information
+  to take action. Please reach out if you have or find the answers we need so
+  that we can investigate further. Thanks!


Maybe we could add a link to our docs here, I use this response for these cases

Closing this as the user hasn't responded or given more information, feel free to reopen with more information if you are still having this problem :).

stsewd · 2019-01-09T15:09:07Z

.github/stale.yml

+# https://probot.github.io/apps/stale/
+
+# Number of days of inactivity before an issue becomes stale
+daysUntilStale: 45


I think we could extend this number a little more, maybe two months?

Hrm, my idea with this bot is not "just close the issues" but also "alert us that we are not paying attention to them". If we find that 45 is to early and distracting, we can increase this number later.

Anyway, if they are correctly labeled (Accepted, Desing decision, etc) it won't affect/distract us at all, though.

humitos · 2019-01-09T15:37:14Z

NOTE: Accepted, Needed: design decision and Status: blocked are exempt of this flow. They won't be closed.

What about the bug label?

I don't want to put Bug label under whitelist because I also want to this bot not to just close issues but also to "remind us" that this is important and we should take a look at it and fix it or tag it properly (as Accepted).

humitos · 2019-01-09T15:41:50Z

We can already filter by emojis in github

Wow! I didn't know that. I think that having a tag will make these issues more globally visible, though.

humitos · 2019-01-09T15:48:10Z

Mergeable and dep looks good, but not sure if they are really helpful, we can just leave a comment.

Mergeable needs more research since I didn't take a deep look, but dep looks useful to me: we can immediately know if a PR depends on another one without reading the whole thread of comments and it's for free :)

agjohnson · 2019-01-09T18:14:51Z

Wow! I didn't know that. I think that having a tag will make these issues more globally visible, though.

I'm -1 on another label here, i won't use this and already use the filtering in github. Also, our repo doesn't get a lot of reactions on issues either way.

ericholscher

Feels like we'll need to tweak this, but having configs is better than the defaults. 👍 Merging

humitos added 3 commits January 9, 2019 10:43

Setup: ProBot No Response

7b8c08d

This bot will help us to close issues after requesting more information to the user that reported it.

Setup: ProBot Stale Bot

544867f

This bot will help us to clean up our repository and stay with issues that are actionable and we do want to work on them at some point. So, after some inactivity the bot will post a comment and if nobody responds to it, the issue will be closed.

Setup: ProBot TODO Bot

6de6c8e

humitos requested a review from a team January 9, 2019 10:07

stsewd reviewed Jan 9, 2019

View reviewed changes

Add link to our docs about triagging

7c8e692

ericholscher reviewed Jan 10, 2019

View reviewed changes

ericholscher approved these changes Jan 10, 2019

View reviewed changes

ericholscher merged commit 0a2fb47 into master Jan 10, 2019

delete-merged-branch bot deleted the humitos/add-probot-configs branch January 10, 2019 15:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Install ProBot #5082

Install ProBot #5082

humitos commented Jan 9, 2019 •

edited

Loading

stsewd commented Jan 9, 2019

stsewd Jan 9, 2019

humitos Jan 9, 2019

stsewd Jan 9, 2019

stsewd Jan 9, 2019

humitos Jan 9, 2019

humitos commented Jan 9, 2019

humitos commented Jan 9, 2019

humitos commented Jan 9, 2019

agjohnson commented Jan 9, 2019

ericholscher left a comment

Install ProBot #5082

Install ProBot #5082

Conversation

humitos commented Jan 9, 2019 • edited Loading

Stale

No Response

todo

Delete Merged Branch

Reminders

stsewd commented Jan 9, 2019

stsewd Jan 9, 2019

Choose a reason for hiding this comment

humitos Jan 9, 2019

Choose a reason for hiding this comment

stsewd Jan 9, 2019

Choose a reason for hiding this comment

stsewd Jan 9, 2019

Choose a reason for hiding this comment

humitos Jan 9, 2019

Choose a reason for hiding this comment

humitos commented Jan 9, 2019

humitos commented Jan 9, 2019

humitos commented Jan 9, 2019

agjohnson commented Jan 9, 2019

ericholscher left a comment

Choose a reason for hiding this comment

humitos commented Jan 9, 2019 •

edited

Loading