Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template improvements in "gold/subscription_form.html" #5049

Merged
merged 3 commits into from
Jan 9, 2019
Merged

Template improvements in "gold/subscription_form.html" #5049

merged 3 commits into from
Jan 9, 2019

Conversation

dojutsu-user
Copy link
Member

  1. Fixes the indentation of some <p> tags.
  2. On line 72, </h3> was the required closing tag, but </h2> was there.
  3. There was missing </div>. It was leading to the whitespace after the footer in https://readthedocs.org/accounts/gold/subscription/

screenshot from 2018-12-30 22-20-33

humitos
humitos reviewed Jan 2, 2019
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. I left a question/comment about a div because I couldn't find where it belongs to.

readthedocs/gold/templates/gold/subscription_form.html Outdated Show resolved Hide resolved
humitos
humitos approved these changes Jan 9, 2019
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@humitos humitos merged commit 05a2a4e into readthedocs:master Jan 9, 2019
@dojutsu-user dojutsu-user deleted the template-changes-gold branch January 10, 2019 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dojutsu-user @humitos