Add temporary method for disabling shallow cloning (#5031) #5036
Conversation
This adds a project feature that allows us to use a standard clone and fetch rather than the shallow clone/fetch introduced in #4939. Eventually we should move this to the web UI, but doing so requires some work to make sure, for example, that git options are only show when 'Project.repo_type' is 'git'. Signed-off-by: Stephen Finucane <[email protected]>
| def test_use_shallow_clone(self): | ||
| repo = self.project.vcs_repo() | ||
| repo.update() | ||
| repo.checkout('submodule') |
There was a problem hiding this comment.
I think it would be good to call .clone (mocked) here and check what were the arguments used to call it. That way, we are sure that we are using use_shallow_clone and it does have an effect in the flow.
|
|
||
| .. note:: | ||
|
|
||
| Temporarily, we support skipping this option as builds that rely on |
There was a problem hiding this comment.
I guess we can remove this note if we go for using a feature flag.
There was a problem hiding this comment.
My thinking was to include this for now so we can unblock the broken builds then decide at a later date whether we wanted to expose this to users. If we don't, we remove the note. If we do, we remove all of this code.
|
Going to hotfix this in a deploy today to unblock you. 👍 We should also plan to document our user-impacting feature flags, so people know they can ask us to turn them on :) |
|
@stephenfin This should now be deployed. Let me know if it is working 👍 |
This adds a project feature that allows us to use a standard clone and
fetch rather than the shallow clone/fetch introduced in #4939.
Eventually we should move this to the web UI, but doing so requires some
work to make sure, for example, that git options are only show when
'Project.repo_type' is 'git'.
Closes #5031