Properly set LANG environment variables #4954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4954 +/- ##
=======================================
Coverage 76.93% 76.93%
=======================================
Files 158 158
Lines 10039 10039
Branches 1259 1259
=======================================
Hits 7724 7724
Misses 1981 1981
Partials 334 334 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #4954 +/- ##
=======================================
Coverage 76.93% 76.93%
=======================================
Files 158 158
Lines 10039 10039
Branches 1259 1259
=======================================
Hits 7724 7724
Misses 1981 1981
Partials 334 334 |
|
NOTE: this change makes my local tests about git tags/branches to pass without problem. |
LANG=C means ASCII and that's why unicode branches/tag tests are failing.
humitos
force-pushed
the
humitos/tox/lang-variable
branch
from
9b30f68
to
87397f2
Compare
ericholscher
approved these changes
Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LANG=C means ASCII and that's why unicode branches/tag tests are failing.
LANG=en_US.UTF-8 is the value that we are using in production. So, I think it's important to use this value in our test suite.