Validate profile form fields #4910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4910 +/- ##
==========================================
+ Coverage 76.65% 76.66% +<.01%
==========================================
Files 158 158
Lines 10057 10057
Branches 1269 1269
==========================================
+ Hits 7709 7710 +1
Misses 2007 2007
+ Partials 341 340 -1
|
stsewd
reviewed
Nov 16, 2018
stsewd
reviewed
Nov 18, 2018
| @@ -35,23 +35,6 @@ def test_edit_profile(self): | |||
| self.assertEqual(self.user.last_name, 'Docs') | |||
| self.assertEqual(self.user.profile.homepage, 'readthedocs.org') | |||
|
|
|||
| def test_edit_profile_with_invalid_values(self): | |||
There was a problem hiding this comment.
I have added the tests.
Just one doubt, max_length is already well-tested feature of django, then what was the need for the these tests ?
There was a problem hiding this comment.
Just to be sure we don't break this in the future
stsewd
reviewed
Nov 18, 2018
|
|
||
| self.assertTrue(len(long_first_name) > 30) | ||
| self.assertTrue(len(long_last_name) > 30) | ||
| self.assertTrue(len(long_homepage) > 100) |
There was a problem hiding this comment.
we could just use string multiplication to make the test shorter and more clear, 'a' * 31
There was a problem hiding this comment.
Thanks for guiding me on this.
I have made the changes.
stsewd
approved these changes
Nov 18, 2018
humitos
approved these changes
Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4887