Do not send notification on VersionLockedError

[humitos]

Instead of LockTimeout exception we are raising VersionLockedError instead. This change introduced a bug that notification started being sent again when a Version was locked and this was really annoying.

[ericholscher]

👍 Definitely annoying to get alerts on locked versions. I wonder if we can do something a bit more robust here. Is it possible to check the failure content for Version Locked or similar? Or some kind of test to catch this?

[humitos]

I wonder if we can do something a bit more robust here. Is it possible to check the failure content for Version Locked or similar?

I made a mistake when refactoring. That was the problem.

Checking for a string will bring the same problems in the future. We will change it to "version locked" (lower case, or similar sentence but different) and we will have the same problem.

What we need here, it's a test case if we want to avoid this problem :) Opened: #4840 for this.