Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start testing config v2 on our project #4838

Merged
merged 3 commits into from
Nov 2, 2018
Merged

Start testing config v2 on our project #4838

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fcb730c
Fail on warning
stsewd Oct 31, 2018
858eb20
Add rtd config file
stsewd Oct 31, 2018
5995bf8
Don't fail on warning
stsewd Oct 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .readthedocs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
version: 2
formats: all
sphinx:
configuration: docs/conf.py
python:
install:
requirements: requirements.txt
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to change this later, when #4740 is deployed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should try and deploy this first.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was thinking the same. But I'm curious to see how this plays on production too 😁

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, lets ship it then :)