Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Docker time limit for max lock age #4747

Merged
merged 2 commits into from
Oct 12, 2018
Merged

Commits on Oct 11, 2018

  1. Use Docker time limit for max lock age

    When building a project, if it tooks more than `REPO_LOCK_SECONDS` and
    while building after that time another build is triggered for the same
    Version and the same builder takes the task the lock will be
    considered "old" and remove and taken by the new build.
    
    This will end up in a collision when accessing the files and it could
    raise an exception like `IOError: [Errno 26] Text file busy`. Also, it
    could fail with another unexpected reasons.
    
    This PR increases the `max_lock_age` to the same value assigned for
    the project to end the build in order:
    
    * custom container time limit or,
    * `settings.DOCKER_LIMITS['time']` or,
    * `settings.REPO_LOCK_SECONDS` or,
    * 30 seconds
    
    Related to #1609
    humitos committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    a6c2481 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2018

  1. Improve docstring

    humitos committed Oct 12, 2018
    Configuration menu
    Copy the full SHA
    100731c View commit details
    Browse the repository at this point in the history