Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make storage syncers extend from a base class #4742

Merged
merged 1 commit into from
Oct 16, 2018
Merged

Make storage syncers extend from a base class #4742

merged 1 commit into from
Oct 16, 2018

Conversation

davidfischer
Copy link
Contributor

It doesn't love that a new positional argument was added in a subclass. I'm not sure if there's a better way to make this work in our lint setup.

@davidfischer davidfischer requested a review from a team October 10, 2018 00:32
humitos
humitos approved these changes Oct 11, 2018
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good!

I don't really care about the lint problem. Your solution with the comment is fine to me.

@davidfischer davidfischer merged commit 5b5edab into master Oct 16, 2018
@davidfischer davidfischer deleted the davidfischer/storage-syncers branch October 16, 2018 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidfischer @humitos