Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint requirement file for py2 #4712

Merged
merged 1 commit into from
Oct 4, 2018
Merged

Lint requirement file for py2 #4712

merged 1 commit into from
Oct 4, 2018

Conversation

humitos
Copy link
Member

@humitos humitos commented Oct 3, 2018

Read the Docs corporate site still uses Python 2.

Reference: https://github.com/rtfd/readthedocs-corporate/pull/395

Read the Docs corporate site still uses Python 2.
@humitos humitos requested a review from a team October 3, 2018 10:02
pylint<2; python_version < '3'

pylint-django==2.0.2; python_version > '3'
pylint-django==0.11.1; python_version < '3'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't know about that flag D:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had no idea about it. Google was my friend :)

@humitos humitos merged commit 1b80b42 into master Oct 4, 2018
@humitos humitos deleted the humitos/lint/py2 branch October 4, 2018 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants