Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix #4247] deleting old search code #4635

Merged
merged 1 commit into from
Sep 17, 2018
Merged

[Fix #4247] deleting old search code #4635

merged 1 commit into from
Sep 17, 2018

Conversation

safwanrahman
Copy link
Member

@safwanrahman safwanrahman commented Sep 15, 2018 •
edited
Loading

This delete the old search code thats not needed in search upgrade
fixes #4247

@safwanrahman safwanrahman mentioned this pull request Sep 15, 2018
Merged
2 tasks
@safwanrahman safwanrahman force-pushed the delete_old branch 3 times, most recently from 0efb00e to 7a0a405 Compare September 15, 2018 02:19
@safwanrahman safwanrahman added this to the Search improvements milestone Sep 15, 2018
@safwanrahman safwanrahman changed the title deleting old search code [Fix #4247] deleting old search code Sep 15, 2018
ericholscher
ericholscher approved these changes Sep 17, 2018
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay :)

@ericholscher ericholscher merged commit 1417f86 into readthedocs:search_upgrade Sep 17, 2018
@safwanrahman safwanrahman mentioned this pull request Sep 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Search improvements
Development

Successfully merging this pull request may close these issues.
2 participants
@safwanrahman @ericholscher