Custom domain clarifications #4514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Note about re-requesting certificates - Note about status on the domain edit screen - Fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some users with older custom domain setups (eg. CNAME to
readthedocs.org), we were not able to issue a certificate for them. While the request to issue certificates retries for a long time, it has been a couple weeks now and they have timed out.My goal with this PR is to notify those users that they need to re-request a certificate -- by saving the domain object -- in order to get one. Likewise, after #4483 we show the status of the domain on the domain edit screen and I want users to see that which might help uncover issues (eg. CAA, incorrect setup, time out).
Lastly, since things have changed I added a link to the docs from the domain edit screen. This should be removed in the near future (October-ish).