Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example and note with usage of trimmed option in blocktrans #4479

Merged
merged 2 commits into from
Aug 22, 2018

Conversation

humitos
Copy link
Member

@humitos humitos commented Aug 6, 2018

Update our docs to suggest the usage of trimmed option when using blocktrans in templates.

Django docs: https://docs.djangoproject.com/en/1.9/topics/i18n/translation/#blocktrans-template-tag

@humitos humitos requested a review from a team August 6, 2018 15:38
@humitos humitos added this to the I18n improvements milestone Aug 6, 2018
@humitos humitos mentioned this pull request Aug 6, 2018
Copy link
Contributor

@ewjoachim ewjoachim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup !

Sorry for launching ideas and leaving it to others to implement, I could have done that myself... Thank you !

docs/i18n.rst Outdated
.. note::

The previous multi-lines examples also use the ``trimmed`` option.
This remove newline characters and replace any whitespace at the beginning and end of a line,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removes ... replaces

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

3 sentences, 2 mistakes. At least is not 3/3. I'm improving my skills 😝

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Language is hard. :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn’t it be "multi-line examples", (without the s after line), though ?

(Not 100% sure)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, yes, it should. 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK! I reached the best score: 3/3 🥇

Thanks!

@ericholscher ericholscher merged commit 4c769d3 into master Aug 22, 2018
@ericholscher
Copy link
Member

👍

@stsewd stsewd deleted the humitos/i18n/trimmed-usage branch August 22, 2018 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants