Disable the ad block nag for ad-free projects #4329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfischer
added
the
PR: work in progress
davidfischer
removed
the
PR: work in progress
ericholscher
approved these changes
Jul 6, 2018
davidfischer
commented
Aug 31, 2018
| @@ -261,7 +261,7 @@ function init() { | |||
| error: function (xhr, textStatus, errorThrown) { | |||
| console.error('Error loading Read the Docs promo'); | |||
|
|
|||
| if (xhr && xhr.status === 404 && rtd.api_host === 'https://readthedocs.org') { | |||
| if (!rtddata.ad_free && xhr && xhr.status === 404 && rtd.api_host === 'https://readthedocs.org') { | |||
There was a problem hiding this comment.
This should have been rtd.ad_free. How did this ever work?
This was referenced Aug 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables the ad block nag if the project is ad free by setting a flag in
READTHEDOCS_DATA. There is still a server side API call to get the ad which checks whether a user or project has gone Gold. This call can be blocked by some ad blockers.There will be a corresponding PR in the sphinx build extensions: https://github.com/rtfd/readthedocs-sphinx-ext
Fixes #4218 for ad-free projects. Ad-free users will still need to disable their ad blocker.