Add feature to build json with html in the same build #4229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
commented
Jun 13, 2018
| def move(self, **__): | ||
| super(HtmlBuilder, self).move() | ||
| if self.project.has_feature(Feature.BUILD_JSON_ARTIFACTS_WITH_HTML): | ||
| # Copy json artifacts to its own directory |
There was a problem hiding this comment.
As the original SearchBuilder isn't executed, we need a move the assets to the other location, I'm not sure if here is the best place, but I feel like it belongs here (since the json output now comes from the html build)
There was a problem hiding this comment.
Seems as good a place as any.
stsewd
commented
Jun 13, 2018
|
|
||
| # Features | ||
| 'generate_json_artifacts': self.project.has_feature( | ||
| Feature.BUILD_JSON_ARTIFACTS_WITH_HTML |
There was a problem hiding this comment.
This is injected in the configuration file
stsewd
commented
Jun 13, 2018
| @@ -1015,13 +1015,16 @@ def add_features(sender, **kwargs): | |||
| ALLOW_DEPRECATED_WEBHOOKS = 'allow_deprecated_webhooks' | |||
| PIP_ALWAYS_UPGRADE = 'pip_always_upgrade' | |||
| SKIP_SUBMODULES = 'skip_submodules' | |||
| BUILD_JSON_ARTIFACTS_WITH_HTML = 'build_json_artifacts_with_html' | |||
There was a problem hiding this comment.
Not sure if the name is the best
|
I just need to figure out how the write tests for this, but it works locally :). |
ericholscher
approved these changes
Jun 13, 2018
| def move(self, **__): | ||
| super(HtmlBuilder, self).move() | ||
| if self.project.has_feature(Feature.BUILD_JSON_ARTIFACTS_WITH_HTML): | ||
| # Copy json artifacts to its own directory |
There was a problem hiding this comment.
Seems as good a place as any.
This was referenced Jun 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement of #4213 Depends on readthedocs/readthedocs-sphinx-ext#43 Closes #3393
I need to add some tests and test manually.