Upgrade packages with pur #4124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$ pur --skip django-tastypie,django,docker-py,elasticsearch,pyelasticsearch,commonmark,stripe,djangorestframework,mkdocs,django-allauth
| @@ -74,7 +71,7 @@ django-formtools==2.1 | |||
| # docker is pinned to 3.1.3 because we found some strange behavior | |||
| # related to timeouts on EXEC with 3.2.1 that's not present with 3.1.3 | |||
| # https://github.com/rtfd/readthedocs.org/issues/3999 | |||
| docker==3.1.3 | |||
| docker==3.3.0 | |||
There was a problem hiding this comment.
Are we sure the above comment is fixed? I'm not sure upgrading all our dependencies all the time is the best way to ensure stability, sadly :/
There was a problem hiding this comment.
We don't.
I tested this locally and everything was working. Although, last time it happened the same, but the problem appeared only in production and we weren't able to reproduce locally.
I'm not sure how I can do a test this in production without breaking everything. Maybe just install this in one of the builders, test it and then undo it?
There was a problem hiding this comment.
I think hopefully it should be fixed. There isn't a great way to test in prod, other than to deploy it sadly. :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$ pur --skip django-tastypie,django,docker-py,elasticsearch,pyelasticsearch,commonmark,stripe,djangorestframework,mkdocs,django-allauth
Closes #4125