Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pur to upgrade python packages #3953

Merged
merged 2 commits into from
Apr 19, 2018
Merged

Conversation

humitos
Copy link
Member

@humitos humitos commented Apr 16, 2018

$ pur --skip django-tastypie,django,docker-py,elasticsearch,pyelasticsearch,commonmark,stripe,djangorestframework,mkdocs,django-allauth
Updated pip: 9.0.3 -> 10.0.0
Updated virtualenv: 15.1.0 -> 15.2.0
Updated Sphinx: 1.7.0 -> 1.7.2
Updated sphinx-rtd-theme: 0.2.5b1 -> 0.3.0
New version for readthedocs-build found (2.0.9), but current spec prohibits updating: readthedocs-build<2.1
Updated django-haystack: 2.7.0 -> 2.8.1
Updated django-extensions: 2.0.0 -> 2.0.6
Updated django-vanilla-views: 1.0.4 -> 1.0.5
Updated lxml: 4.1.1 -> 4.2.1
Updated httplib2: 0.10.3 -> 0.11.3
Updated GitPython: 2.1.8 -> 2.1.9
Updated pytz: 2018.3 -> 2018.4
Updated docker: 3.1.3 -> 3.2.1
Updated sphinxcontrib-httpdomain: 1.6.0 -> 1.6.1
Updated packaging: 16.8 -> 17.1
All requirements up-to-date.

Sphinx==1.7.0
sphinx_rtd_theme==0.2.5b1
Sphinx==1.7.2
sphinx_rtd_theme==0.3.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should wait until readthedocs/sphinx_rtd_theme#610 is solved, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. Let's hold off on this one for now. I'm going to try to get the issues around this resolved.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will stick in 0.2.5b1 until that issue is solved.

@@ -19,20 +19,20 @@ readthedocs-build<2.1
# django-tastypie 0.13.x and 0.14.0 are not compatible with our code
django-tastypie==0.13.0

django-haystack==2.7.0
django-haystack==2.8.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is only used on the API v1, is still worth updating? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this used for elasticsearch?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. It's only for v1 API which we should deprecate.

@agjohnson agjohnson added this to the Cleanup milestone Apr 17, 2018
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though I do worry about breaking stuff that isn't well tested (eg. Docker). It's good to keep these up to date though, so I'm +1 on merging it and then doing dev with it for a while before deploying.

@humitos
Copy link
Member Author

humitos commented Apr 18, 2018

I did some tests locally running different builds and it worked. The good side is that we have a newer version of docker daemon in our servers so it's more likely to be compatible without changes.

@agjohnson agjohnson merged commit 3c02f8f into master Apr 19, 2018
@agjohnson agjohnson deleted the humitos/upgrade/packages branch April 19, 2018 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants