Make adjustments to Projects page #3948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change margins on #project_description to what it seems it was intended to be Adjust project description template
stsewd
reviewed
Apr 15, 2018
| @@ -129,7 +129,7 @@ form.form-wide textarea { | |||
| #content { padding: 50px 0; } | |||
| #content ul { margin-bottom: 20px; } | |||
|
|
|||
| #content #project_description { margin-bottom: 20px; } | |||
| #project_description { margin-top: 20px; } | |||
There was a problem hiding this comment.
It always bothered me to see those elements too close p:
davidfischer
approved these changes
Apr 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going over the changes:
.quietwas removed because it was already defined elsewhere, which didn't make much sense. The line of duplication is line 46.#content #project_descriptionwas simplified to just#project_description.I also made the decision to make the
margin-bottomamargin-topbecause it does nothing otherwise. An example in practice is godot. And if you are to look at the HTML file, its going to end up rendered at the bottom. Essentially, it's useless and I think it was meant for it to be a top margin such that there would be appropriate spacing.I also adjusted the template in
project_details.htmlsuch that it removed the extra id and needless div, and would not leave an empty div in case of there not being a description. That way, it fits the purpose of templating better.