Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save docker image hash to consider when auto wiping the environment #3793

Merged
merged 8 commits into from
Mar 23, 2018
Merged

Save docker image hash to consider when auto wiping the environment #3793

merged 8 commits into from
Mar 23, 2018

Commits on Mar 14, 2018

  1. Remove obsolete code 

    Now, we can access `self.config.build_image` directly.
    @humitos
    humitos committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    af67c19 View commit details
    Browse the repository at this point in the history

  2. Move container_image selection to the init 

    At initialization time we have the project and we already know if the
project has the build image override so we can decide at that point
and save it as a instance attribute.

Then we can use this values from other places inside the same class.
    @humitos
    humitos committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    83afdf1 View commit details
    Browse the repository at this point in the history

  3. Save Docker Image hash in readthedocs-environment.json 

    The hash is used to know if the environment is obsolete and auto-wipe
it if necessary.
    @humitos
    humitos committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    aefada3 View commit details
    Browse the repository at this point in the history

  4. Simplify the class naming

    @humitos
    humitos committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    026a411 View commit details
    Browse the repository at this point in the history

  5. Save the image hash in the json file

    @humitos
    humitos committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    622ef10 View commit details
    Browse the repository at this point in the history

  6. Lint

    @humitos
    humitos committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    ca388c0 View commit details
    Browse the repository at this point in the history

  7. Remove invalid properties from YAML config in tests

    @humitos
    humitos committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    2189b93 View commit details
    Browse the repository at this point in the history

  8. Add test for save_environment_json

    @humitos
    humitos committed Mar 14, 2018
    Configuration menu
    Copy the full SHA
    05d74ae View commit details
    Browse the repository at this point in the history