Changed 'Submit' text on buttons with something more meaningful #3749
Conversation
| @@ -72,7 +72,7 @@ <h4>{% trans "Opting out" %}</h4> | |||
| {% endblocktrans %} | |||
|
|
|||
| <form method="get" action="{% url "gold_subscription" %}"> | |||
| <input type="submit" value="{% trans "I can contribute financially" %}" /> | |||
| <input type="submit" value="{% trans "I can contribute financially." %}" /> | |||
There was a problem hiding this comment.
Not sure if it's ok to include periods within a button.
There was a problem hiding this comment.
It's more like an entire sentence. That's why included that. Should I change it back the way it was?
There was a problem hiding this comment.
I don't have the arguments or the knowledge for choosing one or the other, was just a question p: But in general the PR should only solve the original issue, if you consider something else is needed is better to open a new issue, so your PR isn't blocked by discussions like this :)
There was a problem hiding this comment.
Yes. You are right. I am kind of new here. Sorry! It won't happen again! 👍
There was a problem hiding this comment.
Nothing to worried about. Thanks for your interest on contributing.
There was a problem hiding this comment.
It's a great learning for me. Thanks for your constant help :)
| {% comment %}Translators: The 'or' here is in between 'Submit' and 'delete'.{% endcomment %} | ||
| {% trans "or" %} | ||
| <a href="{% url "projects_delete" project.slug %}">{% trans "delete" %}</a> | ||
| <a href="{% url "projects_delete" project.slug %}">{% trans "delete project" %}</a> |
There was a problem hiding this comment.
Why isn't this capitalized, too?
There was a problem hiding this comment.
I'll update it with changes. Thanks. :)
| @@ -19,10 +19,10 @@ | |||
| </p> | |||
| {{ form.as_p }} | |||
| <p> | |||
| <input style="display: inline;" type="submit" value="{% trans "Submit" %}"> | |||
| <input style="display: inline;" type="submit" value="{% trans "Save" %}"> | |||
| {% comment %}Translators: The 'or' here is in between 'Submit' and 'delete'.{% endcomment %} | |||
There was a problem hiding this comment.
We need to update this comment :)
There was a problem hiding this comment.
This is a great addition! It always bothers me to see a Submit button :)
We don't use title case in our UI, but especially on buttons -- or are at least we're moving away and standardizing on sentence case. I noted a few instances, but there are a few more in this PR. Could you revert those?
| @@ -66,7 +66,7 @@ <h3>{% trans "Build a version" %}</h3> | |||
| <option value="{{ version.slug }}">{{ version.slug }}</option> | |||
| {% endfor %} | |||
| </select> | |||
| <input type="submit" value="{% trans "Build" %}"> | |||
| <input type="submit" value="{% trans "Build Project" %}"> | |||
There was a problem hiding this comment.
As this is a build version form, perhaps this should be Build version instead
There was a problem hiding this comment.
Oh! Yes. You are right. I'll change it right away!
| @@ -18,6 +18,6 @@ | |||
| action="{% url 'projects_integrations_create' project_slug=project.slug %}"> | |||
| {% csrf_token %} | |||
| {{ form.as_p }} | |||
| <input type="submit" value="{% trans "Add integration" %}"> | |||
| <input type="submit" value="{% trans "Add Integration" %}"> | |||
There was a problem hiding this comment.
We don't use title casing on our buttons, or at least shouldn't
There was a problem hiding this comment.
Oh! Okay. I'll revert those changes. 👍
| @@ -17,7 +17,7 @@ | |||
| <li> | |||
| <a class="button" | |||
| href="{% url 'projects_integrations_create' project_slug=project.slug %}"> | |||
| {% trans "Add integration" %} | |||
| {% trans "Add Integration" %} | |||
|
This looks good to me, thanks for your contribution! 🎉 |
This is regarding #3735.
I have changed 'Submit' text on buttons with 'Save', 'Add' etc. Also made some other typo changes.
@stsewd & @davidfischer please have a look.