Show URLS for exact redirect

[stsewd]

Fix #2431

Now the from and to URLS are shown

[humitos]

What about adding something like the docs say?

http://docs.readthedocs.io/en/latest/user-defined-redirects.html

docs.example.com/dev/install.html -> docs.example.com/en/latest/install.html

So, maybe it could say

Prefix Redirect: /dev -> /{default_language}/{default_version}

What do you think?

[humitos]

This is a really good improvement! Thanks.

Take a look at my comment and let me know. This should be ready to get merged soon.

[stsewd]

@humitos done!

Probably we may want to move this representation to the template in the future.

[humitos]

Good job! It's ready to merge for me.

[agjohnson]

Can you post a screenshot of what this looks like with a long redirect path? This will wrap in a strange way.

Similar to some of the other patterns that use this table layout, we should probably move some of the information to a second line of smaller text, similar to the project import page.

[davidfischer]

It does wrap somewhat awkwardly. Perhaps putting it on a second line is the best approach.

On an unrelated note, I cringe a bit anytime I see a button with the label "Submit".

[humitos]

@stsewd would you like to update this PR to use the style you have already used in other PRs (the one with the second line similar to import project page)?

@davidfischer I agree! In this particular case, what would you write? "Create"?

[stsewd]

@agjohnson @humitos now I think that this styles should be more general, probably is better to do that on #3572 https://github.com/rtfd/readthedocs.org/pull/3572/files#diff-9537de04b5e187580d265c8136166aed and then applied them here.

Meanwhile I'll modify the layout.

[stsewd]

@agjohnson @humitos this is how it would look like reusing the styles from #3572

(obviously the redirect name would no be on the urls and a icon instead of the remove text)

[davidfischer]

I think "Create redirect" is great. "Create" is certainly better than "Submit".

[davidfischer]

I think the 2nd line looks good overall.

[humitos]

@stsewd I like your proposal!

I'll use the name of the rediect (Page Redirect, Page Prefix, etc) in the first line and remove it from the second line (gray one). I think it will look nicer.

Seems like everything is converging to a common style. I like that!

[humitos]

@stsewd could you take a look at my last comment? I think that's the only thing missing here to get merged. Can you check if there is anything else missing?

[stsewd]

@humitos I think is better to reuse the same css classes defined on #3572, the image I show here was just the result of a quick copy/paste to see how it will looks like.

[humitos]

@humitos I think is better to reuse the same css classes defined on #3572, the image I show here was just the result of a quick copy/paste to see how it will looks like.

I refer to this comment:

I'll use the name of the rediect (Page Redirect, Page Prefix, etc) in the first line and remove it from the second line (gray one). I think it will look nicer.

So, applying this to your last example from the screenshot, it would be:

Prefix Redirect
/server/ -> /en/latest/

[stsewd]

@humitos done, this is how it looks. Didn't like too much, but is better than before.