Analytics fixes #3558
Merged
Analytics fixes #3558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
davidfischer
commented
Jan 27, 2018
davidfischer
commented
- the analytics ID wasn't coming thru to GA correctly
- the click handler was only working for image clicks not ad text clicks
- the analytics ID wasn't coming thru to GA correctly - the click handler was only working for image clicks not ad text clicks
davidfischer
commented
Jan 27, 2018
| @@ -81,7 +81,7 @@ Promo.prototype.place_promo = function (selector, promo_class) { | |||
| .attr('class', 'rtd-pro-image-wrapper') | |||
| .attr('href', self.link) | |||
| .attr('target', '_blank') | |||
| .on('click', this.click_handler); | |||
| .on('click', self.click_handler); | |||
There was a problem hiding this comment.
This actually wasn't strictly a problem. It is more clear though.
| @@ -97,7 +97,7 @@ Promo.prototype.place_promo = function (selector, promo_class) { | |||
| .attr('class', 'rtd-pro-link') | |||
| .attr('href', self.link) | |||
| .attr('target', '_blank') | |||
| .on('click', this.click_handler); | |||
| .on('click', self.click_handler); | |||
There was a problem hiding this comment.
This was a scoping problem as this in this context is DOM <a> element.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.