Remove outline reset to bring back outline #3512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichardLitt
approved these changes
Jan 13, 2018
|
Thanks! I've been wanting to make this change as well. This probably needs some QA, but I don't think there will be any major problems that get raised with the change. |
|
Looked at this locally and it looks good. It's actually much nicer to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the outline reset for the main site.
This is needed to improve accessibility of the site. Outline is much needed for a lot of keyboard-only users and should not be removed. It's only allowed to be reset if you actually restyle it.
Read more: http://www.outlinenone.com/