Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated python.setup_py_install to be true #3357

Conversation

JavaDevVictoria
Copy link

Updated python.setup_py_install to be true, as per issue 3334: #3334

Updated python.setup_py_install to be true, as per issue 3334: readthedocs#3334
@@ -103,7 +103,7 @@ https://goo.gl/forms/AKEoeWHixlzVfqKT2
python.setup_py_install
```````````````````````

* Default: `False`
* Default: `True`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be done in the code?

I mean, I think it should be False by default.

@agjohnson
Copy link
Contributor

agjohnson commented Dec 14, 2017

I just updated #3334, which appears to be invalid. The default behavior doesn't not install your project. Closing this as invalid as well.

Thanks for the contribution either way though! We can reopen this if #3334 ends up valid afterall.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants