Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Email sending: Allow kwargs for other options #3355

Merged
merged 1 commit into from
Dec 4, 2017
Merged

Email sending: Allow kwargs for other options #3355

merged 1 commit into from
Dec 4, 2017

Conversation

ericholscher
Copy link
Member

No description provided.

@ericholscher ericholscher requested review from davidfischer and agjohnson and removed request for agjohnson December 4, 2017 19:26
agjohnson
agjohnson reviewed Dec 4, 2017
View reviewed changes
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

What's the context of this change though? Its not apparent why this is needed.

@ericholscher
Copy link
Member Author

Wanted to cc things on the ad form.

@ericholscher ericholscher merged commit 76dbd45 into master Dec 4, 2017
@agjohnson agjohnson deleted the more-mail-changes branch December 5, 2017 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agjohnson agjohnson agjohnson left review comments

@davidfischer davidfischer Awaiting requested review from davidfischer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericholscher @agjohnson