Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not convert to bytes the refresh_token #3273

Merged
merged 6 commits into from
Nov 20, 2017

Commits on Nov 15, 2017

  1. Do not convert to bytes the refresh_token

    When the body is encoded, a mix of bytes and unicode happens and it
    fails at this line
    
    https://github.com/requests/requests-oauthlib/blob/c472e6bf0468f1bd52b70a64e9aac92bee41c491/requests_oauthlib/oauth2_session.py#L285
    
    (Pdb) body
    u'grant_type=refresh_token&allow_redirects=True&refresh_token=b%27z9BSRKqf2QD4pcDhqj%27&client_id=CLIENT_ID&client_secret=CLIENT_SECRET'
    
    (note those weird `%27` in the string)
    humitos committed Nov 15, 2017
    Configuration menu
    Copy the full SHA
    236498a View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2017

  1. Configuration menu
    Copy the full SHA
    412496f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f5d3a8a View commit details
    Browse the repository at this point in the history
  3. Fix lint :(

    humitos committed Nov 16, 2017
    Configuration menu
    Copy the full SHA
    3a2e192 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2017

  1. Refactor paginate to handle exception in Bitbucket and Github

    `paginate` method is shared between both services and each service
    implement `get_next_url_to_paginate` and `get_paginated_results`.
    humitos committed Nov 20, 2017
    Configuration menu
    Copy the full SHA
    83a3c62 View commit details
    Browse the repository at this point in the history
  2. Names and attributes fixes

    humitos committed Nov 20, 2017
    Configuration menu
    Copy the full SHA
    0501721 View commit details
    Browse the repository at this point in the history