Drop unnecessary CSP directives for gold view #11605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not seem needed, as there is no inline script src in `subscription_detail.html`. It seems like maybe we wrote this for `subscription_form.html`, which was old. This conditional was breaking the view for me locally, as we don't have any CSP directives for `script-src` locally, we only have these in production. Because of this, there are no other `script-src` exceptions.
|
It's not clear if we actually hit an issue with this view in production or not: I tested a full list of script-src minus "unsafe-inline" and was able to use this view. Before this change, the view was broken locally. We don't seem to actually use inline scripts in this view from what I can tell -- noted at readthedocs/ext-theme#407 |
humitos
approved these changes
Sep 18, 2024
|
This indeed was not required, I don't get the errors on this view anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not seem needed, as there is no inline script src in
subscription_detail.html. It seems like maybe we wrote this forsubscription_form.html, which was old.This conditional was breaking the view for me locally, as we don't have
any CSP directives for
script-srclocally, we only have these inproduction. Because of this, there are no other
script-srcexceptions.