Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better pattern to use PYTEST_OPTIONS #4317

Closed
humitos opened this issue Jul 2, 2018 · 0 comments · Fixed by #7002
Closed

Better pattern to use PYTEST_OPTIONS #4317

humitos opened this issue Jul 2, 2018 · 0 comments · Fixed by #7002
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Milestone
Refactoring

Comments

@humitos
Copy link
Member

humitos commented Jul 2, 2018

In #4095 we incorporate the usage of PYTEST_OPTIONS to define a set of options to be environment-dependent. This way, we can extend/override these options used only in tests from outside (for example, corporate repo).

Although I like it, I had to write a hack to know if we are running in readthedocs or readthedocsinc to know which of these options has to be respected by pytest.

The ugly code is at #4095 (comment) and we need to find a better pattern for this.
@humitos humitos added Improvement Minor improvement to code Accepted Accepted issue on our roadmap labels Jul 2, 2018
@humitos humitos added this to the Refactoring milestone Jul 2, 2018
@humitos humitos mentioned this issue Jul 2, 2018
Merged
stsewd added a commit that referenced this issue Apr 29, 2020
@stsewd
Update conftest
36cebae 
This isn't needed anymore.
Corporate tests pass without this.

Closes #4317
@stsewd stsewd mentioned this issue Apr 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Projects
None yet
Milestone
Refactoring
Development

Successfully merging a pull request may close this issue.

Update conftest readthedocs/readthedocs.org
1 participant
@humitos