Test command versions on master branch
#143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humitos
force-pushed
the
humitos/test-command-versions
branch
2 times, most recently
from
beeed10 to
a56f923
Compare
After the image is built from the current commit, we spin up the container with the image just built and execute some commands to check the versions them.
humitos
force-pushed
the
humitos/test-command-versions
branch
from
57dc520 to
fbedc03
Compare
It will download the image from Docker Hub and use its layers as cache.
This was referenced Oct 19, 2020
|
I'm merging this branch since it's working properly on |
stsewd
reviewed
Oct 19, 2020
| install: | ||
| - pipenv install | ||
| script: | ||
| - pipenv run pytest --suppress-no-test-exit-code | ||
| - docker build . | ||
| - docker build --cache-from readthedocs/build:master -t readthedocs/build:master . |
There was a problem hiding this comment.
looks like we don't the context, you can pass the dockerfile as - < Dockerfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests to check the versions that are running inside the docker image are the ones that we expect for all the versions 5.x, 6.x, 7.x and master.
Once all tests pass on this branch (master) and this PR gets merged, we need to backport this PR into
releases/x.ybranches so they are ran on those docker images as well.Closes #142