Skip to content

June 2025 Python Dependency update#1024

Merged
davidfischer merged 2 commits intomainfrom
davidfischer/python-deps-update-june-2025
Jun 12, 2025
Merged

June 2025 Python Dependency update#1024
davidfischer merged 2 commits intomainfrom
davidfischer/python-deps-update-june-2025

Conversation

@davidfischer
Copy link
Copy Markdown
Collaborator

In addition to general updates, there was a number of additional analyzer updates and more precise pinning.

In addition to general updates,
there was a number of additional analyzer updates and more precise
pinning.
@ericholscher
Copy link
Copy Markdown
Member

I'd be happy to turn off dependabot as well -- those PRs just seem like noise.

Copy link
Copy Markdown
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine, but it seems it's adding dependencies while also updating them? Also, we should really note why we're doing an upper pin on things, otherwise we'll have no idea why/when we can update them.

beautifulsoup4
textacy
spacy
spacy[transformers] >=3.8.7,< 4.0
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a comment whenever we pin something noting why it's pinned.


# Used to parse web pages and get the "main section" of the page
trafilatura
trafilatura >= 2.0.0,<3.0
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar here -- guessing this is an API breakage?


# Numpy v2 has some breaking changes (for now)
numpy<2
sentence-transformers >= 4.1,<5.0
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here? Lots of pinning here we're doing?

@davidfischer
Copy link
Copy Markdown
Collaborator Author

This seems fine, but it seems it's adding dependencies while also updating them? Also, we should really note why we're doing an upper pin on things, otherwise we'll have no idea why/when we can update them.

I'll add notes. There isn't a lot of reason for an upper pin other than to avoid breaking changes. If a major version has breaking changes, shouldn't we be careful in taking them? The minimum pin on some of these is required because versions conflict with other modules.

@davidfischer davidfischer merged commit 122eec6 into main Jun 12, 2025
1 check passed
@davidfischer davidfischer deleted the davidfischer/python-deps-update-june-2025 branch June 12, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants