Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(demo): set root font-family #909

Open
wants to merge 4 commits into
base: next
Choose a base branch
from
Open

style(demo): set root font-family #909

wants to merge 4 commits into from
+5 −0

Conversation

rafegoldberg
Copy link
Contributor

@rafegoldberg rafegoldberg commented Jun 18, 2024 •
edited
Loading

🧰 Changes

  • set the root font-family to the system font
  • update visual test snapshots

🧬 QA & Testing

Check out this branch and run start. If you don't see Times New Roman, this worked! 🎉

@rafegoldberg rafegoldberg added enhancement New feature or request styles Changes related to visual styling labels Jun 18, 2024
kellyjosephprice
kellyjosephprice approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@kellyjosephprice kellyjosephprice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafegoldberg
Copy link
Contributor Author

Urg, will update the visual tests before I merge.

jennspencer
jennspencer approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@jennspencer jennspencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:chefs-kiss:

@rafegoldberg
Copy link
Contributor Author

rafegoldberg commented Jun 18, 2024 •
edited
Loading

Okay, well I tried to update ‘em with -u and it worked locally, but apparently they still don't match on CI! My guess is it's because they're using a different system font? Not sure how to get ‘em to update/match in this scenario; do you have any ideas @kellyjosephprice? Maybe this is why we haven't fixed this issue?

@jennspencer
Copy link
Contributor

@rafegoldberg you'll need to fire up docker and use make updateSnapshot

@rafegoldberg
Copy link
Contributor Author

Nice, that worked—thanks @jennspencer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennspencer jennspencer jennspencer approved these changes

@kellyjosephprice kellyjosephprice kellyjosephprice approved these changes

@trishaprile trishaprile Awaiting requested review from trishaprile

Assignees
No one assigned
Labels
enhancement New feature or request styles Changes related to visual styling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rafegoldberg @jennspencer @kellyjosephprice