This repository was archived by the owner on Nov 28, 2022. It is now read-only.
feat: splitting out our current markdown engine to a new package#514
Merged
feat: splitting out our current markdown engine to a new package#514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #436 coming up very soon, I'm working on a deployment strategy and given that our new Markdown engine is currently being enabled in production via a flag, and is unfortunately reserving the v5 release tag (#458), we're making the decision to split out our existing (legacy) Markdown engine to a new package:
@readme/markdown-magic.With a separate package, we can then merge the new Markdown processor into master and flip between the different parsers based on what we want to use for the project at hand.
Once this is merged in, I'll package it up into NPM and branch off #458 again with some work to allow us to toggle between the different engines.