Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up access to shared storage #581

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Conversation

qnga
Copy link
Member

@qnga qnga commented Oct 25, 2024

WewViews attempt to read all resources at once and by ranges, so range requests reaching a ZIP file are entirely random (for instance range 1 from resource 1, then range 1 from resource 2, then range 2 from resource1, etc.). This PR significantly improves speed (though unfortunately, we still can't reach direct access speed) by

  • Reusing the InputStream when reading a range located after the previous read one.
  • Reading full ZIP entries in one go and caching them when they are small enough.

In addition, fixes the path that imports from intents go through in the testapp.

@qnga qnga requested a review from mickael-menu October 25, 2024 12:04
@qnga qnga marked this pull request as ready for review October 25, 2024 12:36
Copy link
Member

@mickael-menu mickael-menu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thank you.

@mickael-menu mickael-menu merged commit 94ba891 into develop Oct 28, 2024
3 checks passed
@mickael-menu mickael-menu deleted the speedup-shared-storage branch October 28, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants