Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import android-pdf-viewer as a JAR instead of an AAR #562

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

mickael-menu
Copy link
Member

The AAR was not compatible with Maven Central.

@mickael-menu mickael-menu requested a review from qnga August 23, 2024 12:56
@mickael-menu mickael-menu force-pushed the fix/android-pdf-viewer branch from e25f276 to b7b66f9 Compare August 23, 2024 13:07
Copy link
Member

@qnga qnga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I guess that the document adapter cannot be used without the navigator adaptor anymore. I think you can create a common module containing the JAR in adapters/pdfium.

@mickael-menu
Copy link
Member Author

Actually, I guess that the document adapter cannot be used without the navigator adaptor anymore. I think you can create a common module containing the JAR in adapters/pdfium.

No it can, it only depends on pdfium-android which thankfully was already available on Maven Central. android-pdf-viewer is only required by our pdfium-navigator adapter.

@qnga
Copy link
Member

qnga commented Aug 23, 2024

Oh, ok, I had no idea.

@mickael-menu mickael-menu merged commit 160668d into develop Aug 26, 2024
3 checks passed
@mickael-menu mickael-menu deleted the fix/android-pdf-viewer branch August 26, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants