Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix audiobook locators' total progression #553

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

mickael-menu
Copy link
Member

Fixed

Navigator

  • Fixed computing the total progression of audiobook locators.

@mickael-menu mickael-menu requested a review from qnga August 1, 2024 16:27
val itemStartPosition = readingOrder.items
.slice(0 until playback.index)
.mapNotNull { it.duration }
.takeIf { it.size == readingOrder.items.size }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This always failed because of the slice() above. We only have a portion of the reading order.

@mickael-menu mickael-menu merged commit 7c08d29 into develop Aug 1, 2024
3 checks passed
@mickael-menu mickael-menu deleted the fix/audiobook-total-prog branch August 1, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant