You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In a CarouselItem I'm able to put custom markup (as Bootstrap 4's Carousel documentation says you can), and it renders as it should. However, I get a warning in the console saying:
"Failed prop type: Invalid prop children.type of value div supplied to CarouselItem, expected one of [null]."
What should be happening?
There shouldn't be any warning like this, because any type of custom markup should be able to pass as a child to CarouselItem, as per Bootstrap 4 docs.
From what I can see a possible fix would be to change CarouselItem's children PropType to node. Additionally, one should be able to pass down a key, as it's currently using the "src" attribute, which can't be guaranteed if the CarouselItem is custom markup, not an image.
Steps to reproduce issue
Create a Carousel with a CarouselItem that has custom markup as children.
Error message in console
Warning: Failed prop type: Invalid prop `children.type` of value `div` supplied to `CarouselItem`, expected one of [null].
in CarouselItem (at Carousel.js:110)
The text was updated successfully, but these errors were encountered:
Issue description
What is happening?
In a CarouselItem I'm able to put custom markup (as Bootstrap 4's Carousel documentation says you can), and it renders as it should. However, I get a warning in the console saying:
"Failed prop type: Invalid prop
children.type
of valuediv
supplied toCarouselItem
, expected one of [null]."What should be happening?
There shouldn't be any warning like this, because any type of custom markup should be able to pass as a child to CarouselItem, as per Bootstrap 4 docs.
From what I can see a possible fix would be to change CarouselItem's children PropType to node. Additionally, one should be able to pass down a key, as it's currently using the "src" attribute, which can't be guaranteed if the CarouselItem is custom markup, not an image.
Steps to reproduce issue
Error message in console
The text was updated successfully, but these errors were encountered: