-
-
Notifications
You must be signed in to change notification settings - Fork 854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(refactor) coverImageUtil, fakeUser and formatCount common/utils methods #1553
(refactor) coverImageUtil, fakeUser and formatCount common/utils methods #1553
Conversation
formatCount methods inside src/common/utils/
✅ Deploy Preview for reactplayio ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! contributor, thank you for opening a Pull Request 🎉.
@reactplay/maintainers will review your submission soon and give you helpful feedback.
If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well done 👍🏻
@all-contributors please add @saddamhr for code |
I've put up a pull request to add @saddamhr! 🎉 |
Description
PR Summary:
coverImageUtil
,formatDurationCount
,fakeUser
andformatCount
function to use constants for time-related values.SECONDS_IN_MINUTE
andSECONDS_IN_HOUR
) to a separateutilsConstants.ts
file for improved readability and maintainability.These changes improve code organization and ensure easier management of constants across the codebase.
Fixes #1550
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Checklist:
Screenshots or example output
coverImageUtil()
method output that shows nothing break after refactoring, banner image is shown properlyfakeUser()
method output that shows nothing break after refactoring, user data shown properly usingfakeUser()
methodformatDurationCount() and formatViewCount()
methods give us the same output, as the previous