Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play : Final Space API #1284

Closed
wants to merge 7 commits into from
Closed

Conversation

nabendu82
Copy link

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Added a new play for Final Space API through React Project

Type of change

Please delete options that are not relevant.

  • [Y] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Yes

Checklist:

  • [Y] I have performed a self-review of my own code
  • [Y] My changes generate no new warnings
  • [Y] New and existing unit tests pass locally with my changes

Screenshots or example output

https://res.cloudinary.com/dxkxvfo2o/image/upload/v1696418384/final_morncj.png

@netlify
Copy link

netlify bot commented Oct 4, 2023

Deploy Preview for reactplayio ready!

Name Link
🔨 Latest commit 550e097
🔍 Latest deploy log https://app.netlify.com/sites/reactplayio/deploys/65d04638c34381000866a3eb
😎 Deploy Preview https://deploy-preview-1284--reactplayio.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vercel
Copy link

vercel bot commented Oct 4, 2023

@nabendu82 is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! contributor, thank you for opening a Pull Request 🎉.

@reactplay/maintainers will review your submission soon and give you helpful feedback. If you're interested in continuing your contributions to open source and want to be a part of a welcoming and fantastic community, we invite you to join our ReactPlay Discord Community.
Show your support by starring ⭐ this repository. Thank you and we appreciate your contribution to open source!
Stale Marking : After 30 days of inactivity this issue/PR will be marked as stale issue/PR and it will be closed and locked in 7 days if no further activity occurs.

Copy link
Member

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello @nabendu82 I suggest using CDN links for images to reduce the size of our project.

@priyankarpal priyankarpal added play request New Play Request. waiting for reviewers no issue number no issue number, we can't merge the PR labels Oct 7, 2023
Copy link

github-actions bot commented Dec 1, 2023

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. This PR will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

@github-actions github-actions bot added the stale label Dec 1, 2023
@github-actions github-actions bot removed the stale label Dec 5, 2023
Copy link

github-actions bot commented Feb 2, 2024

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. This PR will be closed and locked in 7 days if no further activity occurs. Thank you for your contributions!

Copy link
Member

@priyankarpal priyankarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename extensions name to .jsx

Comment on lines +15 to +27
- Video:

## Implementation Details

Update your implementation idea and details here

## Consideration

Update all considerations(if any)

## Resources

Update external resources(if any)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove these line

Suggested change
- Video:
## Implementation Details
Update your implementation idea and details here
## Consideration
Update all considerations(if any)
## Resources
Update external resources(if any)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the extension name to jsx

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here rename to .jsx

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use different names to target an element for your project. otherwise, it will change the whole reactplay project's CSS

example

If you want to target a container, rename the class name like this or you can use a different name that won't break the site

the code will be like this

.projectname-container{
}

@priyankarpal priyankarpal added the changes required need to change some thing label Feb 17, 2024
@priyankarpal
Copy link
Member

Since there haven't been any updates, we can move forward with closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes required need to change some thing no issue number no issue number, we can't merge the PR play request New Play Request. waiting for reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants