Merge pull request #156 from SimonFrings/tests

Update PHPUnit configuration schema for PHPUnit 9.3 and minor clean up and remove already covered test

.gitattributes

@@ -3,4 +3,5 @@
 /.travis.yml export-ignore
 /examples export-ignore
 /phpunit.xml.dist export-ignore
+/phpunit.xml.legacy export-ignore
 /tests export-ignore

.travis.yml

@@ -29,8 +29,9 @@ jobs:
     - os: osx
 
 install:
-  - composer install --no-interaction
+  - composer install
 
 script:
-  - vendor/bin/phpunit --coverage-text
+  - if [[ "$TRAVIS_PHP_VERSION" > "7.2" ]]; then vendor/bin/phpunit --coverage-text; fi
+  - if [[ "$TRAVIS_PHP_VERSION" < "7.3" ]]; then vendor/bin/phpunit --coverage-text -c phpunit.xml.legacy; fi
   - time php examples/91-benchmark-throughput.php

composer.json

@@ -31,7 +31,7 @@
         "evenement/evenement": "^3.0 || ^2.0 || ^1.0"
     },
     "require-dev": {
-        "phpunit/phpunit": "^9.0 || ^5.7 || ^4.8.35",
+        "phpunit/phpunit": "^9.3 || ^5.7 || ^4.8.35",
         "clue/stream-filter": "~1.2"
     },
     "autoload": {

phpunit.xml.dist

@@ -1,15 +1,19 @@
 <?xml version="1.0" encoding="UTF-8"?>
 
-<phpunit bootstrap="vendor/autoload.php" colors="true">
+<!-- PHPUnit configuration file with new format for PHPUnit 9.3+ -->
+<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" 
+         xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd"
+         bootstrap="vendor/autoload.php"
+         colors="true"
+         cacheResult="false">
     <testsuites>
         <testsuite name="React Test Suite">
             <directory>./tests/</directory>
         </testsuite>
     </testsuites>
-
-    <filter>
-        <whitelist>
+    <coverage>
+        <include>
             <directory>./src/</directory>
-        </whitelist>
-    </filter>
+        </include>
+    </coverage>
 </phpunit>

phpunit.xml.legacy

@@ -0,0 +1,18 @@
+<?xml version="1.0" encoding="UTF-8"?>
+
+<!-- PHPUnit configuration file with old format for PHPUnit 9.2 or older -->
+<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/4.8/phpunit.xsd"
+         bootstrap="vendor/autoload.php"
+         colors="true">
+    <testsuites>
+        <testsuite name="React Test Suite">
+            <directory>./tests/</directory>
+        </testsuite>
+    </testsuites>
+    <filter>
+        <whitelist>
+            <directory>./src/</directory>
+        </whitelist>
+    </filter>
+</phpunit>

tests/TestCase.php

@@ -6,16 +6,6 @@
 
 class TestCase extends BaseTestCase
 {
-    protected function expectCallableExactly($amount)
-    {
-        $mock = $this->createCallableMock();
-        $mock
-            ->expects($this->exactly($amount))
-            ->method('__invoke');
-
-        return $mock;
-    }
-
     protected function expectCallableOnce()
     {
         $mock = $this->createCallableMock();
@@ -61,7 +51,7 @@ protected function createCallableMock()
     public function setExpectedException($exception, $exceptionMessage = '', $exceptionCode = null)
     {
         if (method_exists($this, 'expectException')) {
-            // PHPUnit 5+
+            // PHPUnit 5.2+
             $this->expectException($exception);
             if ($exceptionMessage !== '') {
                 $this->expectExceptionMessage($exceptionMessage);
@@ -70,7 +60,7 @@ public function setExpectedException($exception, $exceptionMessage = '', $except
                 $this->expectExceptionCode($exceptionCode);
             }
         } else {
-            // legacy PHPUnit 4
+            // legacy PHPUnit 4 - PHPUnit 5.1
             parent::setExpectedException($exception, $exceptionMessage, $exceptionCode);
         }
     }

tests/UtilTest.php

@@ -265,9 +265,4 @@ private function createLoopMock()
     {
         return $this->getMockBuilder('React\EventLoop\LoopInterface')->getMock();
     }
-
-    private function notEqualTo($value)
-    {
-        return new \PHPUnit_Framework_Constraint_Not($value);
-    }
 }

tests/WritableStreamResourceTest.php → tests/WritableResourceStreamTest.php

@@ -461,33 +461,6 @@ public function testWritingToClosedWritableResourceStreamShouldNotWriteToStream(
         $this->assertSame('', $filterBuffer);
     }
 
-    /**
-     * @covers React\Stream\WritableResourceStream::handleWrite
-     */
-    public function testErrorWhenStreamResourceIsInvalid()
-    {
-        $stream = fopen('php://temp', 'r+');
-        $loop = $this->createWriteableLoopMock();
-
-        $error = null;
-
-        $buffer = new WritableResourceStream($stream, $loop);
-        $buffer->on('error', function ($message) use (&$error) {
-            $error = $message;
-        });
-
-        // invalidate stream resource
-        fclose($stream);
-
-        $buffer->write('Attempting to write to bad stream');
-
-        $this->assertInstanceOf('Exception', $error);
-
-        // the error messages differ between PHP versions, let's just check substrings
-        $this->assertContainsString('Unable to write to stream: ', $error->getMessage());
-        $this->assertContainsStringIgnoringCase(' Not a valid stream resource', $error->getMessage());
-    }
-
     public function testWritingToClosedStream()
     {
         if ('Darwin' === PHP_OS) {