Clean up test suite

reactphp · Jul 17, 2020 · 4b3b844 · 4b3b844
1 parent 802b41e
commit 4b3b844
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 11 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -3,7 +3,7 @@ language: php
 # lock distro so new future defaults will not break the build
 dist: trusty
 
-matrix:
+jobs:
   include:
     - php: 5.3
       dist: precise

diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -1,15 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 
-<phpunit backupGlobals="false"
-         backupStaticAttributes="false"
-         colors="true"
-         convertErrorsToExceptions="true"
-         convertNoticesToExceptions="true"
-         convertWarningsToExceptions="true"
-         processIsolation="false"
-         stopOnFailure="false"
-         bootstrap="vendor/autoload.php"
->
+<phpunit bootstrap="vendor/autoload.php" colors="true">
     <testsuites>
         <testsuite name="React Test Suite">
             <directory>./tests/</directory>

diff --git a/tests/WritableStreamResourceTest.php b/tests/WritableStreamResourceTest.php
@@ -325,6 +325,10 @@ public function testEndWithoutDataDoesNotCloseIfWritableResourceStreamIsFull()
      */
     public function testEndWithDataClosesImmediatelyIfWritableResourceStreamFlushes()
     {
+        if (defined('HHVM_VERSION')) {
+            $this->markTestSkipped('Not supported on HHVM');
+        }
+
         $stream = fopen('php://temp', 'r+');
         $filterBuffer = '';
         $loop = $this->createLoopMock();
@@ -462,6 +466,10 @@ public function testWritingToClosedWritableResourceStreamShouldNotWriteToStream(
      */
     public function testErrorWhenStreamResourceIsInvalid()
     {
+        if (defined('HHVM_VERSION')) {
+            $this->markTestSkipped('Not supported on HHVM');
+        }
+
         $stream = fopen('php://temp', 'r+');
         $loop = $this->createWriteableLoopMock();