Skip to content

Minor code cleanup, remove dead code and improve code coverage to 100% #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2020
Merged

Minor code cleanup, remove dead code and improve code coverage to 100% #236

merged 1 commit into from
May 21, 2020

Conversation

@clue
Copy link
Member

@clue clue commented May 18, 2020

Refs #235

@clue clue added this to the v1.5.0 milestone May 18, 2020
@clue clue requested review from WyriHaximus and jsor May 18, 2020 15:41
@jsor jsor merged commit b3de2a0 into reactphp:master May 21, 2020
@clue clue deleted the covfefe branch May 21, 2020 19:43
@clue clue mentioned this pull request Jun 21, 2020
Merged
@clue clue mentioned this pull request Feb 1, 2021
Merged
@clue clue mentioned this pull request Dec 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsor jsor jsor approved these changes

@WyriHaximus WyriHaximus WyriHaximus approved these changes

Assignees

No one assigned

Labels

maintenance

Projects

None yet

Milestone

v1.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@clue @jsor @WyriHaximus