Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests on PHPUnit 9 and clean up test suite #42

Merged
merged 2 commits into from
Jul 3, 2020
Merged

Run tests on PHPUnit 9 and clean up test suite #42

merged 2 commits into from
Jul 3, 2020

Conversation

SimonFrings
Copy link
Member

No description provided.

@SimonFrings SimonFrings force-pushed the tests branch 3 times, most recently from c8e6275 to da85788 Compare July 2, 2020 08:24
@clue clue requested review from jsor and WyriHaximus July 2, 2020 08:42
@clue clue added this to the v1.5.1 milestone Jul 2, 2020
clue
clue approved these changes Jul 2, 2020
View reviewed changes
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for the update, changes LGTM! :shipit:

@jsor jsor merged commit c27878c into reactphp:master Jul 3, 2020
@clue clue modified the milestones: v1.5.1, v1.6.0 Jul 10, 2020
@SimonFrings SimonFrings mentioned this pull request Sep 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsor jsor jsor approved these changes

@WyriHaximus WyriHaximus WyriHaximus approved these changes

@clue clue clue approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@SimonFrings @jsor @WyriHaximus @clue