Support parsing DNS config from WMIC on Windows #94
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements DNS server config autodetection on Windows by parsing WMIC output. I've looked into reading this from nslookup (works, but blocks when network is not available), ipconfig /all (difficult to parse due to localization), registry (non-trivial implementation) and wmic (which I ended up using). Afaict this command is available on all Windows versions starting with Windows XP and uses some CSV/JSON-based output format that we can parse.
The WMIC command will now be used on Windows by default by the
Config
class as introduced with #93. This PR includes a number of test cases for the expected WMIC output, but I would to see if anybody else can test this on their local Windows setup. Any feedback is much appreciated!Builds on top of #92 and #93
Refs #29