Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor test clean up and skip failing test on HHVM #165

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Minor test clean up and skip failing test on HHVM #165

merged 1 commit into from
Jul 21, 2020

Conversation

SimonFrings
Copy link
Member

No description provided.

@SimonFrings SimonFrings changed the title Skip failing test on HHVM and short clean up Minor test clean up and skip failing test on HHVM Jul 20, 2020
clue
clue approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for the update, changes LGTM 👍

@clue clue requested review from jsor and WyriHaximus July 20, 2020 12:25
@clue clue added this to the v1.3.1 milestone Jul 20, 2020
@jsor jsor merged commit 1f66dfd into reactphp:master Jul 21, 2020
@clue clue mentioned this pull request Sep 5, 2020
Merged
@clue clue modified the milestones: v1.3.1, v1.4.0 Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsor jsor jsor approved these changes

@WyriHaximus WyriHaximus WyriHaximus approved these changes

@clue clue clue approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@SimonFrings @jsor @WyriHaximus @clue