You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds limited Windows support by omitting any process I/O pipes on Windows. While this means that portability might be limited, it at least allows spawning processes on Windows. Also, this PR includes plenty of tests and documentation for known workarounds, so one can in fact process output using I/O redirections. This has been tested extensively on some Windows 10 installations, but this repository does not currently run any tests on Windows. I consider this to be out of scope for this ticket, but agree that it makes sense to look into test automation in a follow-up PR. In the meantime, you're invited to run this on your local Windows installation or take my word for granted, so now let's get this shipped! ❤️
Sidenote: I/O pipes could be supported if PHP would implement support for named pipes (as opposed to anonymous pipes). If that support is expressed through being able to create and remove named pipes in userland or through some sort of internal creation of named pipes with a random name instead of anonymous pipes, is open.
@CharlotteDunois I agree and I'm looking forward to see more alternatives in PHP userspace in the future! 👍 Some of those options have been discussed in #9 already, so for example we might also be able to set SO_OPENTYPE to SO_SYNCHRONOUS_NONALERT on Windows or other workarounds. I consider this PR to be a starting point and I would love to see more people contribute possible workarounds in the future!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds limited Windows support by omitting any process I/O pipes on Windows. While this means that portability might be limited, it at least allows spawning processes on Windows. Also, this PR includes plenty of tests and documentation for known workarounds, so one can in fact process output using I/O redirections. This has been tested extensively on some Windows 10 installations, but this repository does not currently run any tests on Windows. I consider this to be out of scope for this ticket, but agree that it makes sense to look into test automation in a follow-up PR. In the meantime, you're invited to run this on your local Windows installation or take my word for granted, so now let's get this shipped!
❤️
Resolves / closes #9
Builds on top of #65