Windows test suite compatibility

[jmikola]

This PR is a rebased version of #10 with additional cleanup.

[jmikola]

@moufmouf: Per your explanation in #10 and the above comments, this test fails on Windows. Does the workaround you're proposing in #11 fix this?

[moufmouf]

@jmikola: Yes, this test fails on Windows... In PHP > 5.6.3, it fails. In PHP < 5.6.3, it locks and the test never halts, which is even worst. #11 fixes this test case.

[jmikola]

@moufmouf: I'd appreciate it if you could run these test suite changes on Windows and report back whether they succeed. Based on earlier discussion with @auroraeosrose, I was inclined to make bypass_shell default to true. I also refactored the command-line preparation to ensure all tests are preparing the command-line consistently.

[jmikola]

@moufmouf: Why was the stderr check only added to this test case? Was there a case where it failed on Windows and you caught some output here?

[moufmouf]

@jmikola Here is the result of the test suite running on PHP 5.6.6 (it's a bit long, I put the raw output so you can see what is happening):

PHPUnit 4.5.0 by Sebastian Bergmann and contributors.

Configuration read from D:\Projects\harmony\child-process-pr-win-test-compat\php
unit.xml.dist

.S.SSSSSSSSSSSSSS.S.SSSSSSSSSSSSSS.E.ESS..ESESS.FF

Time: 33.21 seconds, Memory: 5.00Mb

There were 4 errors:

1) React\Tests\ChildProcess\StreamSelectLoopProcessTest::testSetEnhanceSigchildC
ompatibilityCannotBeCalledIfProcessIsRunning
proc_open(): CreateProcess failed, error code - 2

D:\Projects\harmony\child-process-pr-win-test-compat\src\Process.php:98
D:\Projects\harmony\child-process-pr-win-test-compat\tests\AbstractProcessTest.p
hp:31

2) React\Tests\ChildProcess\StreamSelectLoopProcessTest::testIsRunning
proc_open(): CreateProcess failed, error code - 2

D:\Projects\harmony\child-process-pr-win-test-compat\src\Process.php:98
D:\Projects\harmony\child-process-pr-win-test-compat\tests\AbstractProcessTest.p
hp:47

3) React\Tests\ChildProcess\StreamSelectLoopProcessTest::testStartAndAllowProces
sToExitSuccessfullyUsingEventLoop
proc_open(): CreateProcess failed, error code - 2

D:\Projects\harmony\child-process-pr-win-test-compat\src\Process.php:98
D:\Projects\harmony\child-process-pr-win-test-compat\tests\AbstractProcessTest.p
hp:173
D:\Projects\harmony\child-process-pr-win-test-compat\vendor\react\event-loop\Tim
er\Timers.php:90
D:\Projects\harmony\child-process-pr-win-test-compat\vendor\react\event-loop\Str
eamSelectLoop.php:177
D:\Projects\harmony\child-process-pr-win-test-compat\tests\AbstractProcessTest.p
hp:176

4) React\Tests\ChildProcess\StreamSelectLoopProcessTest::testStartAlreadyRunning
Process
proc_open(): CreateProcess failed, error code - 2

D:\Projects\harmony\child-process-pr-win-test-compat\src\Process.php:98
D:\Projects\harmony\child-process-pr-win-test-compat\tests\AbstractProcessTest.p
hp:222

--

There were 2 failures:

1) React\Tests\ChildProcess\StreamSelectLoopProcessTest::testProcessWithFixedOut
putSize with data set #1 (10000, 5)
Failed asserting that 4096 matches expected 10002.

D:\Projects\harmony\child-process-pr-win-test-compat\tests\AbstractProcessTest.p
hp:348

2) React\Tests\ChildProcess\StreamSelectLoopProcessTest::testProcessWithFixedOut
putSize with data set #2 (100000, 5)
Process took longer than expected.
Failed asserting that 32.302847146987915 is equal to 5 or is less than 5.

D:\Projects\harmony\child-process-pr-win-test-compat\tests\AbstractProcessTest.p
hp:350

FAILURES!
Tests: 45, Assertions: 34, Failures: 2, Errors: 4, Skipped: 35.

Note: on PHP 5.5.12, the unit test simply locks due to a PHP bug (that was fixed in PHP 5.5.18 and PHP 5.6.3)

Here is the output (until it locks and stops responding):

Configuration read from D:\Projects\harmony\child-process-pr-win-test-compat\php
unit.xml.dist

.S.SSSSSSSSSSSSSS.S.SSSSSSSSSSSSSS.E.ESS..ESESS..

[jmikola]

@moufmouf: If I understand correctly, the testProcessWithFixedOutputSize cases are expected to fail. Were the earlier four errors expected? I didn't see them mentioned in your previous PR.

CreateProcess failed, error code - 2 seems terribly vague, but it appears to be due to a missing file path (see: mikehaertl/phpwkhtmltopdf#8 (comment)). I assume this is because those tests refer to the sleep and echo commands. Is it possible that enabling the bypass_shell option for proc_open() broke that and they were previously emulated by cmd.exe?

[clue]

Thank you for digging into this and filing this PR! 👍

I still think that getting this feature in makes perfect sense and I'm looking forward to a future update here as per #9 (comment)!

Given that this is currently a WIP and hasn't seen any updates in a while and I don't see it's likely this will get traction any time soon, I will have to close this for now. Please don't see this as discouraging, we would still love to get this feature in and very much appreciate your effort! You can simply complete this feature and update this PR and we're happy to reopen this 👍

Thank you for your effort!