[4.x] Consistent cancellation semantics for async()
and coroutine()
#55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset ensures we're using consistent cancellation semantics for
async()
andcoroutine()
. In particular, callingcancel()
on the resulting promise will now try to cancel the first pending operation only. Cancelling a pending operation would usually throw an exception and thus reject the resulting promise. If this exception in caught inside the fiber/coroutine and another operation is started or if the pending operation does not support cancellation, the fiber/coroutine may continue executing.Refs #42
Changes for
coroutine()
cherry-picked from #54 for 3.x, but also refs cancellation ofasync()
(see #20 and #34)Builds on top of #20, #34 and #48