Add Spring Boot integration. #8
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By implementing `SpringApplicationRunListener`, we can install the agent very early in the lifecycle (`starting` phase).
bsideup
commented
Feb 25, 2019
| * This {@link SpringApplicationRunListener} installs the agent when an app is starting | ||
| * by calling {@link BlockHound#install(BlockHoundIntegration...)}. | ||
| */ | ||
| public class BlockHoundRunListener implements SpringApplicationRunListener, Ordered { |
There was a problem hiding this comment.
@philwebb does it have to be public, or I can make it internal?
There was a problem hiding this comment.
@philwebb, has the Boot team considered making the methods in SpringApplicationRunListener interface default methods now that Java 8 is the baseline?
There was a problem hiding this comment.
Good idea, will add an issue. That API is somewhat unusual as it mainly exists to break a package tangle.
There was a problem hiding this comment.
Good idea, will add an issue.
Thanks
There was a problem hiding this comment.
@philwebb anything to say about the visibility of this class? 😊
bsideup
commented
Feb 25, 2019
spring/src/main/java/reactor/blockhound/spring/BlockHoundRunListener.java
Outdated
Show resolved
Hide resolved
|
I'm going to close this PR since we have a more generic JUnit Platform integration now (see #13) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By implementing
SpringApplicationRunListener, we can install the agentvery early in the lifecycle (
startingphase)./cc @OlegDokuka @philwebb @sbrannen @sdeleuze @ryanjbaxter @spencergibb